Page MenuHomePhabricator

Cumin: allow to ignore exit codes of executed commands
Closed, ResolvedPublic

Description

The API already allow to specify the list of exit codes to be considered successful when executing a command, but it's not possible to set it from the CLI.
Moreover the API doesn't have an easy way to consider any exit code as successful.

Add an option to the CLI to ignore the exit codes of the executed command(s), this can be useful when running troubleshooting commands like grep and such, but might be risky in the general case, so adding also a warning when using it.

Event Timeline

Change 367823 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: improve Command class

https://gerrit.wikimedia.org/r/367823

Change 367824 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] CLI: add an option to ignore exit codes of commands

https://gerrit.wikimedia.org/r/367824

Volans triaged this task as Medium priority.Aug 2 2017, 10:01 AM

Change 367823 merged by jenkins-bot:
[operations/software/cumin@master] Transports: improve Command class

https://gerrit.wikimedia.org/r/367823

Volans removed a project: Patch-For-Review.
Volans moved this task from In Code Review to Done on the SRE-tools board.

Change 367824 merged by jenkins-bot:
[operations/software/cumin@master] CLI: add an option to ignore exit codes of commands

https://gerrit.wikimedia.org/r/367824