Page MenuHomePhabricator

Cumin: improve target management
Closed, ResolvedPublic

Description

The current implementation puts all the execution information in the chosen transport that extends the BaseWorker class.
A good fraction of this information is related to the target hosts, such as the batch size and sleep and future features like percentage batches, shuffling, etc.

I think it makes sense at this point to have a Target class to handle the target-specific configuration and let the BaseWorker delegate to it.

Event Timeline

Change 367825 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: improve target management

https://gerrit.wikimedia.org/r/367825

Volans triaged this task as Medium priority.Aug 2 2017, 10:01 AM

Change 367825 merged by jenkins-bot:
[operations/software/cumin@master] Transports: improve target management

https://gerrit.wikimedia.org/r/367825

Change 373272 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: fix target management improvement

https://gerrit.wikimedia.org/r/373272

Change 373272 merged by jenkins-bot:
[operations/software/cumin@master] Transports: fix target management improvement

https://gerrit.wikimedia.org/r/373272

Volans removed a project: Patch-For-Review.