Page MenuHomePhabricator

Drafts should use core mechanism for configuring accesskeys
Closed, ResolvedPublic

Description

Author: ayg

Description:
Proposed patch (may have some issues, see text)

See bug 16089. The solution to that, r42689, introduced a config variable. This is inconsistent with core, which uses system messages. It also doesn't make use of the magical formats that cause wikibits.js to append " [alt-shift-d]" or similar to the tooltip.

The attached patch should rectify this, but I wasn't able to test it since I don't have Drafts installed. Also, I'm not sure if it's okay for an extension to use messages that aren't prefixed with the extension name -- if not, some tweaks will be needed to core to allow prefixed messages in Linker::titleAttrib() and Linker::accesskey().

Clearly, if the patch is used and more localizations have been added in the meantime, the message keys for the new localizations need to be changed too.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz16153

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:23 PM
bzimport set Reference to bz16153.