Page MenuHomePhabricator
Create Task
Maniphest T18361

Add user and password globals so that those using SubversionShell and closed svn can see diffs
Closed, ResolvedPublic
Actions

Description

Author: skizzerz

Description:
The attached patch adds two globals $wgSubversionUser and $wgSubversionPassword that allow people using SubversionShell with a closed svn to still view diffs, etc. with Special:Code.

Details:
$wgSubversionUser (mixed): String of the username needed to access svn, or false if not needed (default false)
$wgSubversionPassword (mixed): String of the password needed to access svn, or false if not needed (default false)

Both of the above globals are properly escaped before being passed into the shell

Version: unspecified
Severity: enhancement

Details

Reference
bz16361

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:29 PM
• bzimport added a project: MediaWiki-extensions-CodeReview.
• bzimport set Reference to bz16361.
• bzimport created this task.Nov 16 2008, 5:51 PM
• bzimport added a comment.Nov 16 2008, 5:53 PM

skizzerz wrote:

patch to add these two globals

attachment CodeReview.patch ignored as obsolete

• bzimport added a comment.Nov 17 2008, 4:21 AM

skizzerz wrote:

Moving member variables to a private member method instead

per suggestion from brion on IRC

Attached:

CodeReview.patch2 KBDownload

• bzimport added a comment.Nov 17 2008, 9:39 PM

skizzerz wrote:

fixed in r43641

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL