Page MenuHomePhabricator

unclosed SSLSocket ResourceWarning during dry tests
Closed, DeclinedPublic

Description

https://integration.wikimedia.org/ci/job/pywikibot-core-tox-nose34-docker/722/console

10:26:37 WARNING: /usr/lib/python3.4/unittest/mock.py:667: ResourceWarning: unclosed <ssl.SSLSocket fd=7, family=AddressFamily.AF_INET, type=2049, proto=6, laddr=('172.17.0.3', 36786), raddr=('208.80.154.224', 443)>

The warning should be fixed or suppressed.

Event Timeline

Change 405262 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] Fix or suppress some of the expected warnings during dry tests

https://gerrit.wikimedia.org/r/405262

We are already igoring disruptive resource warnings in WarningSourceSkipContextManager. But I'm not sure if it's a good idea to ignore all resource warnings, even the harmless ones like this. May reopen in the future if required.