Page MenuHomePhabricator

#wpReason field on Special:MovePage should be an input, not a textarea
Closed, ResolvedPublic

Description

Author: happy_melon

Description:
Multiline statements are invalid in edit summaries - the newlines are silently discarded. As such, it is confusing and entirely unnecessary to use a <textarea> for the reason input in [[Special:MovePage]]; it should be an <input>.


Version: unspecified
Severity: minor

Details

Reference
bz17130

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:25 PM
bzimport set Reference to bz17130.
bzimport added a subscriber: Unknown Object (MLST).

Other approach: replace \n with space on commit.

happy_melon wrote:

Patch to change the <textarea> to an <input>. Against r45848

Hmn. Attached patch anyway, this is really trivial unless I've missed a glaringly obvious dependency. I don't really follow Brion's comment about it being a "usability regression": why would we be encouraging long comments (and then silently reformatting them) for moves, but not for other log summaries? There should be consistency here: either *all* summary inputs should be textareas, or they should *all* be inputs. Having one different gives the impression that the log summary is somehow different, when in fact that is not the case at all; they're treated *exactly* the same, and the same limitations and issues apply.

Attached:

mike.lifeguard+bugs wrote:

*** This bug has been marked as a duplicate of bug 13627 ***