Page MenuHomePhabricator

Diffs should assume redirect=no
Closed, ResolvedPublic

Description

Author: matthew.britton

Description:
This URL had me confused for a while:

http://en.wikipedia.org/w/index.php?title=Khety_II&diff=266098037

  • Title parameter is "Khety II"
  • Title shown on the page is "Khety II"
  • HTML title attribute is "Khety II"
  • Both revisions in the diff are from the page "Khety II"
  • Both "Revision as of" titles link to old versions of "Khety II"
  • Both "edit" links next to the revision titles link to old versions of "Khety II"

BUT

  • "Next edit" and "Previous edit" links put "Ninth dynasty of Egypt" in the title (though lead to other edits to Khety II)
  • Article, discussion, edit, history, move and watch tabs all link to "Ninth dynasty of Egypt"
  • Diff says "8 intermediate revisions not shown" when there are no intermediate revisions

It is clearly broken behaviour for "article", "discussion", etc. tabs to link to a page other than that shown in the page title, and also broken behaviour for them to link to a page that is not the page either of the revisions being compared belongs to.

The unexpected intrusion of links to [[Ninth dynasty of Egypt]] here is presumably because that's where the current version of [[Khety II]] redirects to. Compare an identical URL with "redirect=no" appended:

http://en.wikipedia.org/w/index.php?title=Khety_II&diff=266098037&redirect=no

Now everything links to the right place.

So, diffs should behave as though "redirect=no" was supplied even if it wasn't.


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/w/index.php?title=Khety_II&diff=266098037

Details

Reference
bz17159

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:27 PM
bzimport set Reference to bz17159.
bzimport added a subscriber: Unknown Object (MLST).

matthew.britton wrote:

Actually, no harm in assuming it for all diffs, which would be simpler.

  • Bug 4973 has been marked as a duplicate of this bug. ***
  • This bug has been marked as a duplicate of bug 22496 ***