Maniphest T191677

Check proper deletion of unused normalized values
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Smalyshev
	Apr 6 2018, 10:54 PM

Description

Since normalized values reference non-normalized values, and vice versa, and normalized values also reference themselves, the query that deletes un-referenced normalized values may not work properly anymore, since it checks that the value does not have any references at all. This needs to be fixed.

Details

	Subject	Repo	Branch	Lines +/-
	Fix cleaning up values & normalized values	wikidata/query/rdf	master	+333 -147

Customize query in gerrit

Event Timeline

Smalyshev created this task.Apr 6 2018, 10:54 PM

Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptApr 6 2018, 10:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Smalyshev renamed this task from Check proper deletion of normalized values to Check proper deletion of unused normalized values.Apr 6 2018, 10:54 PM

Smalyshev triaged this task as Medium priority.Apr 12 2018, 8:32 PM

Smalyshev moved this task from Incoming to Current work on the Wikidata-Query-Service board.Apr 26 2018, 4:51 PM

Change 429532 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/rdf@master] Fix cleaning up values & normalized values

https://gerrit.wikimedia.org/r/429532

gerritbot added a project: Patch-For-Review.Apr 27 2018, 11:35 PM

Smalyshev claimed this task.Apr 28 2018, 7:40 AM

Smalyshev added a project: Discovery-Wikidata-Query-Service-Sprint.Apr 30 2018, 11:23 PM

Smalyshev moved this task from Backlog to In progress on the Discovery-Wikidata-Query-Service-Sprint board.

Smalyshev moved this task from In progress to Needs review on the Discovery-Wikidata-Query-Service-Sprint board.May 1 2018, 10:58 PM

Change 429532 merged by jenkins-bot:
[wikidata/query/rdf@master] Fix cleaning up values & normalized values

https://gerrit.wikimedia.org/r/429532

Smalyshev moved this task from Needs review to Done on the Discovery-Wikidata-Query-Service-Sprint board.May 2 2018, 5:34 PM

Smalyshev closed this task as Resolved.May 7 2018, 7:31 PM