Page MenuHomePhabricator

SRF-Ploticus: Ensure generated hash for plots are unique
Closed, ResolvedPublic

Description

Author: mediawiki

Description:
Currently, SRF-Ploticus creates a hash based on the query params, and if liveupdating is on, the query result set.

Though it may be slim, there is a small chance of a cache collision when two separate identical queries with liveupdating=false may retrieve the wrong results from the cache.

To eliminate this possibility, seed the hash with the article name and the query runnumber as well.


Version: unspecified
Severity: trivial

Details

Reference
bz17573

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:32 PM
bzimport set Reference to bz17573.

mediawiki wrote:

Fixed in revision 47591 (http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=47591).

Seeded hash with $wgArticle->mTitle and $smwgIQRunningNumber to eliminate the possibility of cache collisions for identical ploticus queries across pages.