Page MenuHomePhabricator

AbuseFilter log pages need an extra "navigation table" and log links
Closed, ResolvedPublic

Description

Author: FT2.wiki

Description:
Sample AbuseFilter log entry:
http://en.wikipedia.org/w/index.php?title=Special:AbuseLog&details=16250

Section headers are given for three sections of the page:

"Action parameters"
"Changes made in edit" (a diff), and 
Log listing

However this is a pain for a reviewer, because often the raw data (action parameters) is very long, as in this example, so one can't quickly navigate to the diff. A similar problem is one can't easily navigate to sections such as "old_text", "old_html", "new_text", because the text is very long and it's all presented as one continual list of text. Lastly one can't easily navigate to "last/next log entry for this filter" or other useful log entries either.

PROPOSED IMPROVEMENTS

1/ A "contents table" at the top and use of "id=" to allow quick jumping to the text elements:

  1. Action parameters
  2. Changes made in this edit (diff)
  3. Other Abuse Filter log entries

    or even:
  4. Action parameters 1.1 New HTML 1.2 New text 1.3 Old HTML 1.4 Old text
  5. Changes made in this edit (diff)
  6. Other Abuse Filter log entries

2/ Consider wrapping the old, new text and HTML in "collapse boxes" for ease of use -- most times at least some of those will not be reviewed in detail and they make the page very long and slow down reviewing as one has to "search" via scrolling to find the next box rather than it being quick.


Version: unspecified
Severity: enhancement

Details

Reference
bz18070

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:31 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz18070.

FT2.wiki wrote:

Also noting that the fact I want to see 500 edits in a contributions or page history, doesn't mean that when I look at an AbuseLog specific entry, I want to have the last 500 abuse log entries appended to that detail view :)

No other log view does that (eg when you look at the detail for a deletion, you don't get the last 500 delete actions appended to it); it probably isn't that helpful.

Better would be selective links such as:

"Other events caught by this filter (previous, next, log)
 Other events by this user or IP (previous, next, log)
 Back to main Abuse Filter management page"

Reordered diffs and var dumps in r48697. Perhaps this resolves the bug to your satisfaction?