Page MenuHomePhabricator

Patch radixRegex overmatching
Closed, ResolvedPublic

Description

patch to prevent radixRegex catching empty strings

This was included in a previous patch but overlooked in the merging.

radixRegex in AbuseFilterParser::nextToken currently throws empty string matches against non-numeric data. Those matches are later discarded by another part of the code, but because it is overmatching the number finding code profiles as the 2nd or 3rd most expensive block in nextToken even though numbers are relatively rare.

The attached patch prevents empty string matches.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz18153