Page MenuHomePhabricator
Create Task
Maniphest T203164

Ensure that renewals from partner pages attempt to renew the correct (latest) application.
Closed, ResolvedPublic
Actions

Description

The Renew button on partner pages may not be correctly identifying the user's latest application or renewal to Renew. We should find it by selecting the most recent sent application.

More specifically, we should make sure that this line (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/resources/views.py#L112) is ordering in the right way for users with an imported app and a renewal of that imported app.

Event Timeline

• Samwalton9-WMF created this task.Aug 30 2018, 2:40 PM
Restricted Application added subscribers: Sadads, Aklapper. · View Herald TranscriptAug 30 2018, 2:40 PM
• Samwalton9-WMF triaged this task as High priority.Aug 30 2018, 2:40 PM
• Samwalton9-WMF moved this task from Incoming tasks to Planned on the Library-Card-Platform board.
• Samwalton9-WMF renamed this task from Ensure that renewals from partner pages renew the correct (latest) application. to Ensure that renewals from partner pages attempt to renew the correct (latest) application..Aug 31 2018, 9:49 AM
• Samwalton9-WMF claimed this task.Aug 31 2018, 2:28 PM
• Samwalton9-WMF moved this task from Planned to Done on the Library-Card-Platform board.

In a shocking turn of events, that line wasn't ordering correctly, and is reversed in https://github.com/WikipediaLibrary/TWLight/pull/138, along with some other improvements to that button's functionality.

• Samwalton9-WMF closed this task as Resolved.Aug 31 2018, 2:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits