Page MenuHomePhabricator

Some Abuse Filter log entries shouldn't be there as the actions doesn't match the stated filter
Closed, DeclinedPublic

Description

Author: mike.lifeguard+bugs

Description:
For example on meta:

03:26, 25 March 2009: Krims (Talk | contribs | block) triggered filter 17, performing the action "edit" on User talk:Krims. Actions taken: Block autopromote; Filter description: Vandalistic edit summaries (details) (examine)

But if you look at http://meta.wikimedia.org/w/index.php?title=Special:AbuseLog&details=139 there is nothing that should match filter 17. Furthermore, testing filter 17 at http://meta.wikimedia.org/wiki/Special:AbuseFilter/examine/log/139 shows that in fact the edit *doesn't* match filter 17 - so why is it logged?


Version: unspecified
Severity: major

Details

Reference
bz18490

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:32 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz18490.

matthew.britton wrote:

quite serious if true

Given test case matches for me, it's because of a buggy filter.

Remember to test against the version of the filter which was in effect at the time, in this case, http://meta.wikimedia.org/wiki/Special:AbuseFilter/history/17/item/90

("X" rlike summary) will *always* match for empty summaries regardless of what "X" is.

For the expected result, reverse "X" and summary.

mike.lifeguard+bugs wrote:

An chance we can get some indication when the log entry applies to an old version of the filter rather than the current one? This is *very* confusing otherwise. Either the revision number or just top/not top would be excellent.