Page MenuHomePhabricator

PDF rendering now accepts inline font sizes but doesn't adjust line spacing to suit
Closed, ResolvedPublic


Author: grysmith

When using large fonts, the updated collection extension now accepts inline font-sizes, but because it doesn't also adjust the line feed sizing at the same rate, lines overwrite each other causing them to gather at the top of the page, in a big mess.

Line feed spacing should be adjusted to suite font sizes.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:38 PM
bzimport added a project: Collection.
bzimport set Reference to bz19223.

development wrote:

Could you please supply an example article where font sizing is a problem.

grysmith wrote:

Sure try the following:

<p style="text-align:center;font-size:480%;font-weight:bold;">LINE ONE</p>
<p style="text-align:center;font-size:480%;font-weight:bold;">LINE TWO</p>

In wikilanguage this will result in two separate lines of text, but when converted to PDF
the second line overwrites the first one because the line spacing is not being adjusted to suite the font size.

development wrote:

Ok, I can confirm the problem. Interestingly enough, if inline spans are used, the Mediawiki renders the on top of each other but the PDF writer does it right...

Check for examples.

Anyways I'll look into the problem you mention above

volker.haas wrote:

The problem with overlapping paragraphs is due to a bug in the PDF toolkit (reportlab) we're using. I submitted the bug:

As soon as the bug is fixed I'll update the reportlab version.

volker.haas wrote:

The latest reportlab version is now used in mwlib.ext. This fixes the above issue