Page MenuHomePhabricator

Only first five template inclusions work
Closed, ResolvedPublic

Description

Author: timwi

Description:
BUG MIGRATED FROM SOURCEFORGE
http://sourceforge.net/tracker/index.php?func=detail&aid=967833&group_id=34373&atid=411192
Originally submitted by John Ky (newhoggy) 2004-06-07 01:48

Suppose I add the following text to a page:

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

{{msg:Mediaweapon}}

The page will only include the first five instances of
{{msg:Mediaweapon}}. The rest of them behave as if
they were: [[Template:Mediaweapon]]

  • Additional comments ------------------------

Date: 2004-06-07 06:08
Sender: SF user hashar

This is hardcoded in parser.php:
define( "MAX_INCLUDE_REPEAT", 5 );

It's to prevent a possible attack :o)

Date: 2004-06-07 07:25
Sender: SF user phil_e

hahar, this feature is boring e.g. on fr you know we use a
lot of:

{{msg:le}} [externllink]
{{msg:le}} [externllink]
etc.

~phe


Date: 2004-06-07 10:15
Sender: nobody
Logged In: NO

Thanks. I'll choose a slightly bigger number for now.
Would it be possible to relax this constraint for small
templates?


Date: 2004-06-09 04:28
Sender: SF user hashar

This is hardcoded site wide. I don't think a template should
be used that much.

The only reason so far to change this setting is the example
of fr.wikipedia.org. The {{msg:le}} template is used before
each external link for the purpose of showing a little earth

icon. That should be replaced by a css tweak for .

Date: 2004-06-14 05:17
Sender: SF user thrasher6669

just as another thought, i'm using templates on my wiki:
gentoo-wiki.com and i can easyly get into areas where i can
use a template 5+ even 10+ times, just ran into this
problem today...

I'm using it to help facilitate uniform looking pages, my
site contains much code snippets and i have provided in the
form of a template a uniform table to show off this code
e.g.( {{code box|code title| Your code here}} )

and with the possible code snippets getting quite large on
some page i could easyly use 10+. Now i could see something
similar happening on wikipedia or other wiki's.

i was just wondering what kind of attack this is trying to
prevent... I havent had a change to look at the code but i
would assume you are using regex to do replacements.

sorry if i dident make much sense there...
oh heres and example of page that _could_ use my templates
extensivly: http://gentoo-wiki.com/HOWTO_setup_a_home-server
(I would be replacing all of the green boxes with the

example above http://gentoo-wiki.com/Template:Box_Code)

Date: 2004-08-16 08:01
Sender: SF user timwi

This bug has been migrated to MediaZilla:
http://bugzilla.wikipedia.org/show_bug.cgi?id=95
Please leave additional comments or attachments there.


Version: unspecified
Severity: normal

Details

Reference
bz124

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 6:46 PM
bzimport set Reference to bz124.
bzimport added a subscriber: Unknown Object (MLST).

rowan.collins wrote:

Duplicate migration

*** This bug has been marked as a duplicate of 95 ***