Page MenuHomePhabricator

The names of CSS classes should have underscores instead of spaces
Closed, ResolvedPublic

Description

Author: Ruslik00

Description:
See, for instance

http://en.wikipedia.org/w/index.php?title=Kanwar_Pal_Singh_Gill&action=history

Here each tag (i.e. Tag: References removed) is wrapped in <span class="mw-tag-marker mw-tag-marker-references removed>. But 'mw-tag-marker-references' and 'removed' are separated by a space, which means that there are actually two classes 'mw-tag-marker-references' and 'removed'. On the other hand each tagged entry in the history is wrapped in <li class="mw-tag-references_removed">, which correctly has an underscore symbol. The same problem appears in the recent changes. See for example

http://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=references+removed

Can spaces in class names used in <span> tags be replaced with underscores?


Version: unspecified
Severity: normal

Details

Reference
bz19783

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:40 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz19783.

Works fine for me.

<li class="mw-tag-references_removed">

Never mind, I was looking at a later part, which I fixed in r53391.

Ruslik00 wrote:

Thank you, Andrew.