Unit test MediaWiki communication works fine
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	May 11 2019, 8:40 PM

Description

Required skills

Basic Python knowledge.

Problem

Developers might break MediaWiki communication methods (defined in trackersite/tracker/models.py, MediaInfo class) unintentionally, which breaks Tracker unless an user notices the bug.

Proposed solution

Implement tests for MediaInfo.add_to_mediawiki, MediaInfo.remove_from_mediawiki and MediaInfo.store_mediawiki_data. You don't need to actually write anything into MediaWiki when tests are runned to consider this task completed, however, if you decide to do so, it will be taken into account when Wikimedia decides about the winners.

Student is expected to send a patch for wikimedia-cz/tracker repository, hosted at Wikimedia Gerrit. When claiming task on GCI website, student should claim a respective Phabricator task as well.

Materials

Tracker in production
Test Tracker version - you can play with Tracker freely here
Codebase

Details

	Subject	Repo	Branch	Lines +/-
	Test MediaWiki communication works fine	wikimedia-cz/tracker	master	+45 -2

Customize query in gerrit

Event Timeline

Urbanecm created this task.May 11 2019, 8:40 PM

Urbanecm moved this task from Inbox to Ready (PM's approval not needed) on the WMCZ-Tracker board.

Urbanecm added a project: User-Urbanecm.Aug 25 2019, 11:57 PM

Urbanecm moved this task from Backlog to GCI on the User-Urbanecm board.Aug 25 2019, 11:59 PM

Urbanecm updated the task description. (Show Details)Aug 26 2019, 4:14 PM

Urbanecm added a project: Google-Code-in-2019.Aug 26 2019, 4:20 PM

Urbanecm moved this task from Ready (PM's approval not needed) to GCI on the WMCZ-Tracker board.Aug 26 2019, 5:08 PM

Urbanecm updated the task description. (Show Details)Oct 12 2019, 4:56 PM

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Oct 29 2019, 7:32 PM

Urbanecm removed a project: User-Urbanecm.Nov 24 2019, 7:36 PM

alcarazzam claimed this task.Jan 6 2020, 1:02 PM

alcarazzam updated the task description. (Show Details)

Hi!
I don't understand well what I need to do to do this task.

If I sent requests to MediaWiki, it will update Wikimedia data, no?
What is supposed that I need to write into MediaWiki, so it will be taken into account when Wikimedia decides about the winners?

Regards

Hi, you can mock the methods with https://docs.python.org/3/library/unittest.mock.html, and assert the methods are called as expected.

Change 564773 had a related patch set uploaded (by Alcarazzam; owner: Alcarazzam):
[wikimedia-cz/tracker@master] Test MediaWiki communication works fine

https://gerrit.wikimedia.org/r/564773

gerritbot added a project: Patch-For-Review.Jan 14 2020, 8:08 PM

Change 564773 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Test MediaWiki communication works fine

https://gerrit.wikimedia.org/r/564773

alcarazzam closed this task as Resolved.Jan 19 2020, 1:46 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2020, 2:10 PM