Page MenuHomePhabricator

wikieditor.css .ui-widget !important conflicts?
Closed, ResolvedPublic

Description

Author: mdale

Description:
In wikieditor.css you have:
.ui-widget {
font-size: 13px !important;
}

This may not play predictiably well with other componets using the jquery-ui themeing system?
a) is this the the best place for this?
b) could it target the toolbar stuff specifically?

Even if we agree all ui-widgets should be font-size 13 on our site things like !important on a base j-query.ui rule make it tricky to override if necessary.


Version: unspecified
Severity: normal

Details

Reference
bz20349

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:56 PM
bzimport set Reference to bz20349.

This was clearly not the best way to do this - it's been fixed by providing a complete jquery-ui theme call vector which matches vector. We need to create one for monobook as well and do some smart switching. But yeah, this has been removed already.