Page MenuHomePhabricator

Headers from templates given wrong IDs
Closed, ResolvedPublic


Author: wikimedia-bugzilla

If you include a template with headers in an article with it's own headers, the
headers from the templates have the wrong IDs, like this:

Header in article (id="1")

Header from template (id="1")

Header2 from template (id="2")

Header2 in article (id="2")

...which leads to unexpected results when clicking on the edit link to a section
(you may be sent to edit a completely different section).

Is this possible to fix? If not, we should probably disallow headers in templates...

I've marked this as major because, although it has a workaround, users may not
realise what has happened, leading to inadvertent screw-ups...

Version: 1.3.x
Severity: major



Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 6:47 PM
bzimport set Reference to bz266.

wikimedia-bugzilla wrote:

(Sorry, marked wrong bug as resolved)

muke wrote:

Note also that if there isn't a native header corresponding to the template's bogus ID; e.
g. the article is like this--

Header in article (id="1")

Header from template (id="1")

Header2 from template (id="2")

--the user clicking the [edit] link for the header with id 2 will be presented with an
empty edit box.

Either the included page shouldn't generate [edit] links, or the [edit] links should point
to the included page directly (in which case the user must be informed his edits could
affect many pages).

jeluf wrote:

Fixed in CVS HEAD and REL1_3. See Bug 60

river wrote:

This isn't fixed, but the behaviour is wrong in a different way. The edit links
are now numbered 1, 2, 3, 4... as if they were all in the article. See

river wrote:

*** Bug 543 has been marked as a duplicate of this bug. ***

river wrote:

Now fixed in 1.3, 1.4 and live on WP.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:15 AM