Page MenuHomePhabricator
Create Task
Maniphest T23074

Don't call $wgUser->getSkin() on OutputPage::getHeadScripts()
Closed, ResolvedPublic
Actions

Description

OutputPage::getHeadScripts() calls $sk = $wgUser->getSkin();, which is unneeded, since the skin is already passed as $sk as parameter.

Version: 1.16.x
Severity: enhancement

Details

Reference
bz21074

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:52 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz21074.
• bzimport added a subscriber: Unknown Object (MLST).
Platonides created this task.Oct 9 2009, 10:26 PM
Platonides added a comment.Oct 9 2009, 10:27 PM

Fix

Attached:

bug_21074.patch422 BDownload

IAlex added a comment.Oct 10 2009, 7:55 AM

Fixed in r57608.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL