Page MenuHomePhabricator

Long titles not truncated in Title object for checks
Closed, ResolvedPublic

Description

Author: timwi

Description:
BUG MIGRATED FROM SOURCEFORGE
http://sourceforge.net/tracker/index.php?func=detail&aid=879509&group_id=34373&atid=411192
Originally submitted by Nobody/Anonymous - nobody 2004-01-19 00:09

Article titles get truncated to 255 characters.

On the test wikipedia, I created [[TestA]]
(contents: "This is '''TestA'''. I will create [[TestB]].")
and [[TestB]] (contents: "This is '''TestB'''. I created
[[TestA]]."), then moved both [[TestA]] and then
[[TestB]] to [[123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456]]. The final 6 was
truncated from the resulting article title, leaving a
broken redirect to the full title from [[TestA]] and
[[TestB]]. The article at [[123...345]] is the previous
[[TestA]]. The previous [[TestB]] appears to be gone.

I prefer not to perform the experiment on a real
wikipedia, and I don't have sysop access on the test
wikipedia, so I haven't been able to try
deleting/restoring it, to see if the contents or history of
[[TestB]] survived somehow.

[[User:Cyp| ''Cyp'']] 23:07, 18 Jan 2004 (UTC)

  • Additional comments ------------------------

Date: 2004-03-15 16:49
Sender: SF user hashar

Related to bug 855544 (long page name)
https://sourceforge.net/tracker/?
func=detail&atid=411192&aid=855544&group_id=34373

Software should not allow a title to be changed to a title that
don't fit in the database. Code is already patched when
creating a new page, need to be implemented when moving
page now :0)


Version: unspecified
Severity: major

Details

Reference
bz327

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 6:48 PM
bzimport set Reference to bz327.
bzimport added a subscriber: Unknown Object (MLST).

timwi wrote:

Sounds like a security problem; raising priority.

I wasn't able to reproduce the bug with the CVS version. I have a error message
(The requested page title was invalid, empty, or an incorrectly linked
inter-language or inter-wiki title.) if I try to move an article to [[123456789
123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789
123456]]. Works fine with [[123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789
123456789 123456789 123456789 123456789 12345]]

In REL1_4 and current HEAD there is a hard-coded check in Title::secureAndSplit(), which does the validity checks. Too-long
titles are rejected explicitly now, rather than truncated silently.

Resolving as FIXED.