Page MenuHomePhabricator

File upload doesn't quite validate names right
Closed, ResolvedPublic

Description

Author: timwi

Description:
BUG MIGRATED FROM SOURCEFORGE
http://sourceforge.net/tracker/index.php?func=detail&aid=720843&group_id=34373&atid=411192
Originally submitted by Brion Vibber (vibber)<a href="/help/icon_legend.php?context=user_wantsdonations&amp;user_id=446709&amp;return_to=%2F"><IMG src="http://images.sourceforge.net/images/icons/donate.png" alt="Accepting Donations" border="0" width="16" height="16"></a> 2003-04-14 02:26

Circumstance:
A file is uploaded whose name is not a valid wiki page
title (invalid characters, such as #). The filename is
munged with the intent of making a legal title.

Expected behavior:
Even hideously deformed title should be turned into
something legal.

Actual behavior:
Some, such as containing #, do not result in a legal
title. The resulting image page cannot be accessed
correctly through the wiki (ie for deletion or renaming).

Example:
Upload of image something like &quot;E with # blah blah.png&quot;
mismunged into 'E_with_'. The resulting name is
invalid: it ends with a space which gets trimmed off by
most other functions. And, of course, the remainder of
the filename is cropped instead of just the offending
character being blanked out, so is doubly wrong.

Seriousness:
Requires manual intervention to clean up the bad
entries from the tables. No serious data loss, as
original uploaded immediately recognizes that it did
not succeed and uploads under a new title.

  • Additional comments ------------------------

Date: 2003-04-14 02:30
Sender: SF user vibber

Likely shares some issues with #695913 Bad titles not

properly filtered on page creation.

Date: 2004-08-09 23:41
Sender: SF user jeluf

Checked in a fix that addresses the #'s. Replaces them by
hyphens so that there are no problems with underscore-merging.

SpecialUpload.php, rev. 1.31

Any additional issues left?


Version: unspecified
Severity: normal

Details

Reference
bz348

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 6:52 PM
bzimport set Reference to bz348.
bzimport added a subscriber: Unknown Object (MLST).

skoon40 wrote:

kawaser5.jpeg

kawaser5.jpeg

Attached:

kawaser5.jpeg (85 KB)

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:23 AM