Page MenuHomePhabricator
Create Task
Maniphest T238947

Unauthorized people can subscribe to "changes of documents" notification
Open, HighPublic
Actions

Description

Problem

You can add yourself as a subscriber of document changes, even you are unauthorized to see the documents.

Proposed solution

Prohibit users who do not have permission to see documents to subscribe to document changes.

Student is expected to send a patch for wikimedia-cz/tracker repository, hosted at Wikimedia Gerrit. When claiming task on GCI website, student should claim a respective Phabricator task as well.

Materials

Details

SubjectRepoBranchLines +/-
Add check to not send notifs to users who can't see the affected file.wikimedia-cz/trackermaster+2 -0
Customize query in gerrit

Event Timeline

Janbery created this task.Nov 22 2019, 8:01 PM
Urbanecm renamed this task from unauthorized people can see changes of documents to Unauthorized people can subscribe to "changes of documents" notification.Nov 24 2019, 7:35 PM
Urbanecm updated the task description. (Show Details)
Urbanecm moved this task from Inbox to GCI on the WMCZ-Tracker board.Nov 24 2019, 7:37 PM
Urbanecm added a project: Google-Code-in-2019.
Urbanecm subscribed.

Imported as https://codein.withgoogle.com/tasks/5725591563665408/

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Nov 24 2019, 7:43 PM
Safan41 claimed this task.Jan 2 2020, 2:37 AM
Urbanecm removed Safan41 as the assignee of this task.Jul 21 2020, 10:21 PM
Urbanecm added a subscriber: Safan41.
Urbanecm triaged this task as High priority.Jul 21 2020, 10:26 PM
Urbanecm added a project: good first task.Jul 21 2020, 10:27 PM
Urbanecm moved this task from GCI to Ready (PM's approval not needed) on the WMCZ-Tracker board.Jul 21 2020, 10:28 PM
WelpThatWorked claimed this task.Aug 4 2022, 8:27 PM
gerritbot added a comment.Aug 27 2022, 1:09 AM

Change 826928 had a related patch set uploaded (by WelpThatWorked; author: WelpThatWorked):

[wikimedia-cz/tracker@master] Add check to not send notifs to users who can't see the affected file.

https://gerrit.wikimedia.org/r/826928

gerritbot added a project: Patch-For-Review.Aug 27 2022, 1:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL