Page MenuHomePhabricator

Import Dump pages/sec readout innacurate when using "--skip-to"
Open, Needs TriagePublic

Description

When using the "--skip-to" cli argument, importDump.php still assumes that it has started from page 0 when reporting number of pages imported per second, resulted in inflated numbers when starting at non-zero pages.

Calculation is currently:

pageCount / ( currentTime - startTime )

It should be:

(pageCount - startPage) / (currentTime - startTime)

Relevant code is here:
https://github.com/wikimedia/mediawiki/blob/7c4a3f8aae57066236b83ec21dc0ef2f5f2c4ead/maintenance/importDump.php#L261