Page MenuHomePhabricator

write unittest to check prefetch ranges for checkpoint files
Closed, ResolvedPublic

Description

See https://gerrit.wikimedia.org/r/#/c/operations/dumps/+/585264/
Not all files were being returned for prefetch; we should have unit testing to cover the case where multiple files are required for a pagerange that does not correspond to any of the previous run's output files.

This likely contributed to the slowness of the dump runs in March, although a look at the % prefetched in the logs didn't show anything too awful.

Event Timeline

ArielGlenn triaged this task as Medium priority.Apr 1 2020, 4:11 PM
ArielGlenn created this task.

Change 585355 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[operations/dumps@master] add test of get_prefetch_arg requiring multiple prefetch files

https://gerrit.wikimedia.org/r/585355

Change 585355 merged by ArielGlenn:
[operations/dumps@master] add test of get_prefetch_arg requiring multiple prefetch files

https://gerrit.wikimedia.org/r/585355