Page MenuHomePhabricator

Deprecate WikiError
Closed, ResolvedPublic



The WikiError class is used only in the Mail backend, very isolated areas in SpecialImport and SpecialUserrights, and a few odd bits scattered through filerepo; its documentation says it was implemented "because PHP4 doesn't have exceptions". We now require PHP5, which *does* have exceptions, although I'm not entirely sure that they're entirely suitable for all the uses. But between exceptions, Message string errors, and Status objects, this system is completely duplicated and extremely inconvenient to keep around; the mail system in particular creeps all over the place.

Version: 1.17.x
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:00 PM
bzimport set Reference to bz23119.

I brought this evil into the world; I'll take it out... assigning to self.

Special:Userrights done in r65131, updated filerepo comments in r65128 since they use FileRepoStatus and not WikiError.

Marking this as FIXED since it was marked as deprecated in r77870 (last usage from core removed in 77800).