Page MenuHomePhabricator
Create Task
Maniphest T251603

Duplicator incompatible with 1.33: Call to a member function getId() on null
Closed, DuplicatePublic
Actions

Description

[XYtBGf4qO5tFANELvYHIIQAAAAE] /wiki/%D9%88%DB%8C%DA%98%D9%87:Duplicator Error from line 1384 of /home/wikicod/domains/wikicod.ir/public_html/w/includes/page/WikiPage.php: Call to a member function getId() on null

Backtrace:

    0 /home/wikicod/domains/wikicod.ir/public_html/w/includes/page/Article.php(2793): WikiPage->updateRevisionOn(Wikimedia\Rdbms\DatabaseMysqli, NULL, NULL, NULL)
    1 /home/wikicod/domains/wikicod.ir/public_html/w/extensions/Duplicator/Duplicator.page.php(339): Article->updateRevisionOn(Wikimedia\Rdbms\DatabaseMysqli, NULL)
    2 /home/wikicod/domains/wikicod.ir/public_html/w/extensions/Duplicator/Duplicator.page.php(115): SpecialDuplicator->duplicate(Title, Title, boolean)
    3 /home/wikicod/domains/wikicod.ir/public_html/w/includes/specialpage/SpecialPage.php(569): SpecialDuplicator->execute(NULL)
    4 /home/wikicod/domains/wikicod.ir/public_html/w/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
    5 /home/wikicod/domains/wikicod.ir/public_html/w/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
    6 /home/wikicod/domains/wikicod.ir/public_html/w/includes/MediaWiki.php(865): MediaWiki->performRequest()
    7 /home/wikicod/domains/wikicod.ir/public_html/w/includes/MediaWiki.php(515): MediaWiki->main()
    8 /home/wikicod/domains/wikicod.ir/public_html/w/index.php(42): MediaWiki->run()
    9 {main}

Duplicator extension not working in version 1.33 and later. I wrote patch to fix it.

Here's the bug
Here's the patch

Details

SubjectRepoBranchLines +/-
Fix MW 1.33 incompatibility by rewriting the duplicate methodmediawiki/extensions/DuplicatorREL1_33+81 -28
Fix MW 1.33 incompatibility by rewriting the duplicate methodmediawiki/extensions/Duplicatormaster+75 -26
Customize query in gerrit

Event Timeline

Anysite created this task.May 1 2020, 12:22 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 1 2020, 12:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from Apply patch to fix Duplicator in 1.33 to Duplicator incompatible with 1.33: Call to a member function getId() on null.May 1 2020, 12:59 PM
Aklapper updated the task description. (Show Details)

@Anysite: Thanks for reporting this. In the future, please report the actual bug, otherwise we only have tickets which are all called "Apply patch to fix something". :)

gerritbot added a comment.May 1 2020, 1:02 PM

Change 591434 had a related patch set uploaded (by Aklapper; owner: Anysite):
[mediawiki/extensions/Duplicator@master] Fix MW 1.33 incompatibility by rewriting the duplicate method

https://gerrit.wikimedia.org/r/591434

gerritbot added a project: Patch-For-Review.May 1 2020, 1:02 PM
gerritbot added a comment.May 7 2020, 2:42 PM

Change 594970 had a related patch set uploaded (by Anysite; owner: Anysite):
[mediawiki/extensions/Duplicator@REL1_33] Fix MW 1.33 incompatibility by rewriting the duplicate method

https://gerrit.wikimedia.org/r/594970

Anysite added a comment.May 7 2020, 2:44 PM

Trying to amend commit as asked results new commit:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Duplicator/+/594970

Aklapper added a comment.May 7 2020, 5:53 PM

@Anysite: It should not when following https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29

gerritbot added a comment.May 7 2020, 5:53 PM

Change 591434 abandoned by Aklapper:
Fix MW 1.33 incompatibility by rewriting the duplicate method

Reason:
Superseded by https://gerrit.wikimedia.org/r/594970

https://gerrit.wikimedia.org/r/591434

Aklapper closed this task as a duplicate of T212813: Duplicator extension throws error Call to a member function getId() on null.Nov 30 2020, 9:01 AM
gerritbot added a comment.Feb 17 2021, 8:20 PM

Change 594970 abandoned by Umherirrender:
[mediawiki/extensions/Duplicator@REL1_33] Fix MW 1.33 incompatibility by rewriting the duplicate method

Reason:
release is end of life

https://gerrit.wikimedia.org/r/594970

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits