Page MenuHomePhabricator

Upgrading to 1.34: Cannot create an actor for a usable name that is not an existing user: user_id=0 user_name="XXXX"
Closed, ResolvedPublic

Description

When upgrading from 1.32 to 1.34, running update.php fails with this error:

Running .../extensions/SocialProfile/UserRelationship/maintenance/migrateOldUserRelationshipUserColumnsToActor.php...
CannotCreateActorException from line 2323 of .../includes/user/User.php: Cannot create an actor for a usable name that is not an existing user: user_id=0 user_name="XXXXXXX"
#0 .../extensions/SocialProfile/UserRelationship/maintenance/migrateOldUserRelationshipUserColumnsToActor.php(62): User->getActorId(Object(Wikimedia\Rdbms\MaintainableDBConnRef))
#1 .../maintenance/Maintenance.php(1746): MigrateOldUserRelationshipUserColumnsToActor->doDBUpdates()
#2 .../includes/installer/DatabaseUpdater.php(1036): LoggedUpdateMaintenance->execute()
#3 .../includes/installer/DatabaseUpdater.php(490): DatabaseUpdater->runMaintenance('MigrateOldUserR...', '...')
#4 .../includes/installer/DatabaseUpdater.php(458): DatabaseUpdater->runUpdates(Array, true)
#5 .../maintenance/update.php(205): DatabaseUpdater->doUpdates(Array)
#6 .../maintenance/doMaintenance.php(99): UpdateMediaWiki->execute()
#7 .../maintenance/update.php(277): require_once('...')
#8 {main}

Apparently the issue is because it creates the user with user_name but doesn't populate its user_id.

Event Timeline

Looks easy to fix. Patch incoming shortly

This also happens in Comments extension... ugh

Running .../extensions/Comments/includes/../sql/../maintenance/migrateOldCommentsUserColumnsToActor.php...
CannotCreateActorException from line 2323 of .../includes/user/User.php: Cannot create an actor for a usable name that is not an existing user: user_id=0 user_name="XXXXXX"
#0 .../extensions/Comments/maintenance/migrateOldCommentsUserColumnsToActor.php(99): User->getActorId(Object(Wikimedia\Rdbms\MaintainableDBConnRef))
#1 .../maintenance/Maintenance.php(1746): MigrateOldCommentsUserColumnsToActor->doDBUpdates()
#2 .../includes/installer/DatabaseUpdater.php(1036): LoggedUpdateMaintenance->execute()
#3 .../includes/installer/DatabaseUpdater.php(490): DatabaseUpdater->runMaintenance('MigrateOldComme...', '...')
#4 .../includes/installer/DatabaseUpdater.php(458): DatabaseUpdater->runUpdates(Array, true)
#5 .../maintenance/update.php(205): DatabaseUpdater->doUpdates(Array)
#6 .../maintenance/doMaintenance.php(99): UpdateMediaWiki->execute()
#7 .../maintenance/update.php(277): require_once('...')
#8 {main}

Change 593964 had a related patch set uploaded (by Martineznovo; owner: Martineznovo):
[mediawiki/extensions/SocialProfile@master] Fix actor migration scripts

https://gerrit.wikimedia.org/r/593964

Change 593965 had a related patch set uploaded (by Martineznovo; owner: Martineznovo):
[mediawiki/extensions/Comments@master] Fix actor migration scripts

https://gerrit.wikimedia.org/r/593965

Change 593965 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Fix actor migration scripts

https://gerrit.wikimedia.org/r/593965

Change 593964 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Fix actor migration scripts

https://gerrit.wikimedia.org/r/593964