dbctl: instance edit should format all the data in the normal yaml key/value mapping
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Kormat
	Sep 21 2020, 1:23 PM

Description

The section body is using the json-style k/v mapping, which makes it awkward to add new groups. You either have to continue to work in the json-style, or convert the existing data to yaml-style and then add the new groups.

An example:

P12685 (An Untitled Masterwork)

1	# Editing object codfw/db2124
2	host_ip: 10.192.16.19
3	note: ''
4	port: 3306
5	sections:
6	s6: {percentage: 100, pooled: true, weight: 400}

Ideally this should look like:

# Editing object codfw/db2124
host_ip: 10.192.16.19
note: ''
port: 3306
sections:
  s6:
    percentage: 100
    pooled: true
    weight: 400

Related Objects

Mentioned In: T263459: dbctl: instance edit workflow will throw away all changes if you forget to use sudo
Mentioned Here: P12685 (An Untitled Masterwork)

Event Timeline

Kormat created this task.Sep 21 2020, 1:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2020, 1:23 PM

Kormat triaged this task as Medium priority.Sep 21 2020, 1:24 PM

Kormat mentioned this in T263459: dbctl: instance edit workflow will throw away all changes if you forget to use sudo.

I just noticed that if an instance is already in some groups, the formatting is different again:

# Editing object codfw/db2117
host_ip: 10.192.48.34
note: ''
port: 3306
sections:
  s6:
    groups:
      dump: {pooled: true, weight: 100}
      vslow: {pooled: true, weight: 100}
    percentage: 100
    pooled: true
    weight: 300

dbctl: instance edit should format all the data in the normal yaml key/value mappingOpen, MediumPublicActions

Description

Related Objects

Event Timeline

dbctl: instance edit should format all the data in the normal yaml key/value mapping
Open, MediumPublic
Actions