text on the same line as a comment breaks comment parsing
Closed, ResolvedPublic

Assigned To
Unknown Object (Diffusion Commit)
Unknown Object (Diffusion Commit)

Author: gangleri

Dear friends,

Please take a look at http://pl.wikipedia.org/w/wiki.phtml?
title=Rasy_ps%C3%B3w&action=history and see two versions:

(bież) (poprz) 23:47, 4 paź 2004 (Gangleri)
(bież) (poprz) 23:45, 4 paź 2004 (Gangleri
de:Hunderasse -> de:Liste der Hunderassen)

The difference between them is only a "carriage return":
The older one contains:
<!--- no category here so far --->[[de:Liste der Hunderassen]]
The newer one contains:
<!--- no category here so far --->
[[de:Liste der Hunderassen]]

I was surprised, that the older version shows only one language
at "in other languages" and the newer seven.

Regards Reinhardt

Version: 1.3.x
Severity: normal
OS: Windows XP
Platform: PC
URL: http://pl.wikipedia.org/w/wiki.phtml?title=Rasy_ps%C3%B3w&action=history

bzimport added a project: MediaWiki-Parser.Via ConduitNov 21 2014, 6:56 PM
bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz644.
bzimport created this task.Via LegacyOct 5 2004, 12:49 AM
bzimport added a comment.Via ConduitNov 8 2004, 8:34 PM

rowan.collins wrote:

The problem appears to be that the other links were sandwiched between two
comments, and the text on the same line as the first confused the parser into
ignoring everything until after the second. A simplified test-case is:

<!--a comment-->deadly text
invisible text
<!--another comment-->

or even:

<!--a comment-->deadly text
invisible text
stray markup-->

In both cases, the page renders as "Intro Outro", the parser seemingly pairing
the 1st "<!--" with the 2nd "-->"; note that without the second comment there at
all, everything appears as you would expect. However, I notice that this appears
to have been fixed in CVS, in that the test server doesn't show the same
problem: http://test.wikipedia.org/wiki/Comments displays as it should. So
presumably, this will be fixed when 1.4 goes stable, but whether it's severe
enough that the necessary change should be tracked down and backported, I'll
leave to someone else to decide.

brion added a comment.Via ConduitDec 11 2004, 11:25 PM

1.4 release imminent, resolving as fixed.

epriestley added a commit: Unknown Object (Diffusion Commit).Via DaemonsMar 4 2015, 8:20 AM
epriestley added a commit: Unknown Object (Diffusion Commit).

Add Comment