Page MenuHomePhabricator
Create Task
Maniphest T268228

Removed method 'dieUsage' in ApiApprove
Closed, ResolvedPublic
Actions

Description

ApiApprove uses the removed method dieUsage.
It was deprecated since 1.29 and should be replaced by dieWithError.

Details

SubjectRepoBranchLines +/-
Replace dieUsage with dieWithErrormediawiki/extensions/ApprovedRevsmaster+3 -3
Customize query in gerrit

Event Timeline

Octfx created this task.Nov 19 2020, 12:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2020, 12:39 PM
gerritbot added a comment.Nov 19 2020, 12:40 PM

Change 641980 had a related patch set uploaded (by Octfx; owner: Octfx):
[mediawiki/extensions/ApprovedRevs@master] Replace dieUsage with dieWithError

https://gerrit.wikimedia.org/r/641980

gerritbot added a project: Patch-For-Review.Nov 19 2020, 12:40 PM
Aklapper added a project: Technical-Debt.Nov 19 2020, 2:28 PM
gerritbot added a comment.Nov 19 2020, 4:12 PM

Change 641980 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Replace dieUsage with dieWithError

https://gerrit.wikimedia.org/r/641980

Maintenance_bot removed a project: Patch-For-Review.Nov 19 2020, 5:10 PM
HouseBlaster subscribed.Dec 3 2022, 1:09 AM

Has this been resolved?

Aklapper closed this task as Resolved.Dec 3 2022, 12:43 PM
Aklapper assigned this task to Octfx.

Yes. Thanks for the ping.

HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Dec 3 2022, 7:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL