Page MenuHomePhabricator

Toolinfo records do not always have a url value
Closed, ResolvedPublic

Description

When generating Toolinfo v1 output, the "url" attribute is required. Striker currently returns a toolforge.org URL if the is_webservice flag is set and falls back to returning the docs URL. If the webservice flag is not set and the docs url is not populated this results in an empty "url" attribute which violates the v1 spec.

Falling back to providing a link to the tool's info page in Striker seems like a reasonable fix.

Event Timeline

bd808 triaged this task as Medium priority.Dec 21 2020, 6:38 PM
bd808 created this task.

Change 651244 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker@master] toolinfo: Use local tool info URL as fallback for "url"

https://gerrit.wikimedia.org/r/651244

Change 651244 merged by jenkins-bot:

[labs/striker@master] toolinfo: Use local tool info URL as fallback for "url"

https://gerrit.wikimedia.org/r/651244

bd808 changed the task status from Open to In Progress.Apr 20 2022, 2:46 PM
bd808 claimed this task.