Page MenuHomePhabricator

ProofreadPage page number markers for pages marked "without text" are not suppressed
Closed, ResolvedPublic

Description

On enWS, the [[MediaWiki:Proofreadpage_pagenum_template]] template is invoked even for pages without text.

According to the following code, such pages should not receive a page number:

				if ( $qualityLevel !== PageLevel::WITHOUT_TEXT ) {
					$pagenum = $pageNumber->getRawPageNumber( $language );
					$formattedNum = $pageNumber->getFormattedPageNumber( $language );
					$out .= '<span>{{:MediaWiki:Proofreadpage_pagenum_template|page=' . $text .
						"|num=$pagenum|formatted=$formattedNum}}</span>";
				}

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ProofreadPage/+/refs/heads/master/includes/Parser/PagesTagParser.php#234

Event Timeline

Change 672375 had a related patch set uploaded (by Inductiveload; owner: Inductiveload):
[mediawiki/extensions/ProofreadPage@master] Return int (as documented) for DB page quality

https://gerrit.wikimedia.org/r/672375

Change 672375 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Return int (as documented) for DB page quality

https://gerrit.wikimedia.org/r/672375

Inductiveload claimed this task.

This is now working at enWS, at least.