Page MenuHomePhabricator
Create Task
Maniphest T278258

Return `origin` as part of toolinfo API responses
Closed, ResolvedPublic
Actions

Description

Return the origin field for a toolinfo record as part of the /api/tools/* and /api/search/tools/ response body. This can be used by UI implementations to hint about the editability of a given record. Specifically origin=crawler records cannot be edited using PUT /api/tools/{name} to prevent edit warring between the crawler and the UI.

Details

SubjectRepoBranchLines +/-
search: add 'origin' facetwikimedia/toolhubmain+23 -0
api: return `origin` with toolinfowikimedia/toolhubmain+8 -1
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Mar 23 2021, 7:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2021, 7:46 PM
gerritbot added a comment.Mar 28 2021, 8:40 PM

Change 675336 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):
[wikimedia/toolhub@main] api: return origin with toolinfo

https://gerrit.wikimedia.org/r/675336

gerritbot added a project: Patch-For-Review.Mar 28 2021, 8:40 PM

Change 675337 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):
[wikimedia/toolhub@main] search: add 'origin' facet

https://gerrit.wikimedia.org/r/675337

bd808 claimed this task.Mar 28 2021, 8:41 PM
bd808 added a project: Developer-Advocacy (Jan-Mar 2021).
bd808 moved this task from Backlog to Review on the Toolhub board.
Restricted Application added a project: User-bd808. · View Herald TranscriptMar 28 2021, 8:41 PM
gerritbot added a comment.Apr 1 2021, 9:52 PM

Change 675336 merged by jenkins-bot:

[wikimedia/toolhub@main] api: return `origin` with toolinfo

https://gerrit.wikimedia.org/r/675336

jenkins-bot mentioned this in rWTHU3452a3ff465c: api: return `origin` with toolinfo.Apr 1 2021, 9:52 PM
gerritbot added a comment.Apr 2 2021, 12:41 AM

Change 675337 merged by jenkins-bot:

[wikimedia/toolhub@main] search: add 'origin' facet

https://gerrit.wikimedia.org/r/675337

bd808 mentioned this in rWTHU1f5f79df307e: search: add 'origin' facet.Apr 2 2021, 12:41 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 2 2021, 1:10 AM
bd808 closed this task as Resolved.Apr 2 2021, 4:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits