Page MenuHomePhabricator
Create Task
Maniphest T278657

Editing inserts "empty" values for blank collections
Closed, ResolvedPublicBUG REPORT
Actions

Description

Saving an edit to a toolinfo record through the UI sets several values to non-null state. This can most easily be seen in a raw API response which will contain values like:

"url_alternates": [
    {}
  ],

Details

SubjectRepoBranchLines +/-
toolinfo: ignore empty objects in url_multilingual collectionswikimedia/toolhubmain+5 -3
toolinfo: ignore empty objects in url_multilingual collectionswikimedia/toolhubmain+2 -1
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Mar 28 2021, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2021, 9:15 PM
bd808 claimed this task.Apr 6 2021, 10:07 PM
bd808 moved this task from Backlog to In Progress on the Toolhub board.
bd808 added a project: Developer-Advocacy (Apr-Jun 2021).
Restricted Application added a project: User-bd808. · View Herald TranscriptApr 6 2021, 10:07 PM
gerritbot added a comment.Apr 8 2021, 11:12 PM

Change 678115 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] toolinfo: ignore empty objects in url_multilingual collections

https://gerrit.wikimedia.org/r/678115

gerritbot added a project: Patch-For-Review.Apr 8 2021, 11:12 PM
gerritbot added a comment.Apr 10 2021, 2:41 AM

Change 678115 merged by jenkins-bot:

[wikimedia/toolhub@main] toolinfo: ignore empty objects in url_multilingual collections

https://gerrit.wikimedia.org/r/678115

bd808 mentioned this in rWTHU048ae4d209f2: toolinfo: ignore empty objects in url_multilingual collections.Apr 10 2021, 2:42 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 10 2021, 3:10 AM
bd808 closed this task as Resolved.Apr 11 2021, 10:56 PM
gerritbot added a comment.Apr 13 2021, 4:00 AM

Change 678681 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] toolinfo: ignore empty objects in url_multilingual collections

https://gerrit.wikimedia.org/r/678681

gerritbot added a project: Patch-For-Review.Apr 13 2021, 4:00 AM
gerritbot added a comment.Apr 13 2021, 8:54 PM

Change 678681 merged by jenkins-bot:

[wikimedia/toolhub@main] toolinfo: ignore empty objects in url_multilingual collections

https://gerrit.wikimedia.org/r/678681

bd808 mentioned this in rWTHU5f11e518f5f1: toolinfo: ignore empty objects in url_multilingual collections.Apr 13 2021, 8:54 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 13 2021, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL