Currently, there are test cases only for the Vuex stores search and locale in files search.spec.js and locale.spec.js, respectively. There need to be similar test cases written for Vuex stores: users, tools, auditlogs, crawler, and api.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| js: Set nyc code coverage to enforcement mode | wikimedia/toolhub | main | +12 -6 | |
| Test cases for remaining Vuex store operations | wikimedia/toolhub | main | +2 K -708 |
Event Timeline
Comment Actions
Change 679592 had a related patch set uploaded (by Srishakatux; author: Srishakatux):
[wikimedia/toolhub@main] Test cases for remaining Vuex store operations
Comment Actions
Change 679592 merged by jenkins-bot:
[wikimedia/toolhub@main] Test cases for remaining Vuex store operations
Comment Actions
Looking so much better!
=============================== Coverage summary =============================== Statements : 78% ( 390/500 ) Branches : 61.88% ( 138/223 ) Functions : 77.22% ( 139/180 ) Lines : 77.82% ( 386/496 ) ================================================================================
Still not ready to turn on 85% coverage enforcement in CI, but getting close. :)
Comment Actions
Change 685610 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):
[wikimedia/toolhub@main] js: Set nyc code coverage to enforcement mode
Comment Actions
Change 685610 merged by jenkins-bot:
[wikimedia/toolhub@main] js: Set nyc code coverage to enforcement mode