Maniphest T280915

Handle visiting non-existent query
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	BrandonXLF
	Apr 22 2021, 10:11 AM

Tags

Referenced Files

None

Subscribers

Description

When visiting a query that doesn't exist, for example, https://quarry.wmflabs.org/query/542707, the lack of a query should be handled and an error page should be shown. Right now the a Python error is raised (sqlalchemy.orm.exc.NoResultFound: No row was found for one() from the line query = g.conn.session.query(Query).filter(Query.id == query_id).one()).

Details

	Subject	Repo	Branch	Lines +/-
	Use one_or_none to handle non-existent queries	analytics/quarry/web	master	+33 -10

Customize query in gerrit

Event Timeline

BrandonXLF created this task.Apr 22 2021, 10:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2021, 10:11 AM

Change 682030 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[analytics/quarry/web@master] Use one_or_none to handle non-existent queries

https://gerrit.wikimedia.org/r/682030

gerritbot added a project: Patch-For-Review.Apr 23 2021, 3:01 AM

rook closed this task as a duplicate of T290874: Quarry returns 500 rather than 404 when asked for an invalid query ID.May 19 2022, 4:24 PM

Change 682030 abandoned by Vivian Rook:

[analytics/quarry/web@master] Use one_or_none to handle non-existent queries

Reason:

Resolved in https://phabricator.wikimedia.org/T290874

https://gerrit.wikimedia.org/r/682030

Maintenance_bot removed a project: Patch-For-Review.May 19 2022, 4:31 PM