Page MenuHomePhabricator
Create Task
Maniphest T283553

SVG toolbar icons cropped under "Listings" on Portuguese Wikivoyage in WikiEditor (SVG files rendered in bigger size, so only part of them being displayed)
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

there is a problem in the interface: when one opens the source code editor, there are some links in the taskbar to add the common templates automatically, but they appear, today, disfigured and it is not possible to understand their functions, can someone help? or where I can get help on this?

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

https://ibb.co/M8grrFg

Event Timeline

felipedafonseca created this task.May 24 2021, 11:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2021, 11:45 PM
Kizule added a project: MediaWiki-User-Interface.May 25 2021, 12:19 AM
Aklapper edited projects, added WikiEditor (2010); removed MediaWiki-User-Interface.May 25 2021, 7:40 AM
Aklapper added a subscriber: Kizule.

(@Kizule: This is the WikiEditor toolbar and not in the MediaWiki core codebase itself - see https://www.mediawiki.org/wiki/Editor for all of them... :)

Aklapper renamed this task from Problems with the WikiVoyage.pt to Distorted SVG items for "Listings" on Portuguese Wikivoyage in WikiEditor toolbar.May 25 2021, 7:42 AM
Aklapper updated the task description. (Show Details)
Aklapper removed a subscriber: Kizule.
Aklapper added a project: MediaWiki-extensions-Listings.May 25 2021, 8:21 AM

I could reproduce in Firefox 88 and Chrome 90, so it's not related to browser rendering engines.
And I cannot reproduce on English Wikivoyage.

Screenshot from 2021-05-25 09-42-47.png (482×978 px, 96 KB)

The toolbar loads the SVG files (not any PNG thumbnails) as background images.
These SVG files themselves render fine when opened separately from their URL.

Manually increasing the CSS values of width and height for .tool-button, it seems that the SVG file rendering ignores the size request, so we only see a small part of the SVG file being rendered:

Screenshot from 2021-05-25 10-19-39.png (657×1 px, 304 KB)

Aklapper renamed this task from Distorted SVG items for "Listings" on Portuguese Wikivoyage in WikiEditor toolbar to SVG toolbar icons cropped under "Listings" on Portuguese Wikivoyage in WikiEditor (SVG files rendered in bigger size, so only part of them being displayed).May 25 2021, 8:23 AM
Aklapper added a comment.May 25 2021, 8:34 AM

Looking at https://pt.wikivoyage.org/wiki/MediaWiki:Common.js and its customizeToolbar code and comparing to https://el.wikivoyage.org/wiki/MediaWiki:Listings.js or https://en.wikivoyage.org/wiki/MediaWiki:Common.js , those other sites instead load the PNG thumbnail versions with 22px size, instead of the SVG files (with no size definition) themselves.

Edu subscribed.May 27 2021, 4:37 PM

@felipedafonseca Hi! I have already asked a local administrator (DARIO SEVERI) to correct the problem. Please report other issues here

Edu closed this task as Resolved.May 27 2021, 4:37 PM
felipedafonseca added a comment.May 27 2021, 5:20 PM

Very nice thanks!!!

Aklapper edited projects, added WMF-General-or-Unknown; removed MediaWiki-extensions-Listings, WikiEditor (2010).May 30 2021, 12:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits