Page MenuHomePhabricator

Add context helper for creating reversion revisions
Closed, ResolvedPublic

Description

There are now several places in the codebase where we setup for using the reversion library that could be made more resilient against future changes by introducing a custom context manager. The boilerplate looks like:

with reversion.create_revision():
    reversion.add_meta(RevisionMetadata)
    reversion.set_user(user)
    if comment is not None:
        reversion.set_comment(comment)
    # Model create/update logic goes here

Something like this would be nicer:

with reversion_context(user, comment):
    # Model create/update logic goes here

Event Timeline

Change 779156 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] api: Add context helper for creating reversion revisions

https://gerrit.wikimedia.org/r/779156

Change 779156 merged by jenkins-bot:

[wikimedia/toolhub@main] api: Add context helper for creating reversion revisions

https://gerrit.wikimedia.org/r/779156

Change 786342 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-04-21-215651-production

https://gerrit.wikimedia.org/r/786342

Change 786342 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Bump container version to 2022-04-21-215651-production

https://gerrit.wikimedia.org/r/786342