Page MenuHomePhabricator

Sortable tables are currently misleading (sorts page, not full dataset)
Closed, ResolvedPublicBUG REPORT

Description

The sort headers on tables like https://toolhub-demo.wmcloud.org/members are a great UX idea. Unfortunately right now they are also misleading to users. The sorts that they perform are local to the current page of results being displayed in the table rather than the global dataset behind the paginated set. Sorting this page by username as an example will order the rows on the current screen, but likely will not actually show you all the accounts starting with "A" when sorting the first page of results.

The fix for this issue would be to connect the sort order with the backend data query and issue a new query with the desired sort when the sort direction or column changes. This may or may not require adding some additional sort key support to the particular API endpoint backing a particular table, but generally that is a simple fix in the django code.

Event Timeline

bd808 changed the subtype of this task from "Task" to "Bug Report".Oct 13 2021, 9:26 PM

Change 756043 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] ui: Fix sorting bug in tables

https://gerrit.wikimedia.org/r/756043

Change 757991 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] ui: Fix sorting bug in tables

https://gerrit.wikimedia.org/r/757991

Change 757991 abandoned by Raymond Ndibe:

[wikimedia/toolhub@main] ui: Fix sorting bug in tables

Reason:

abandoned for I38fc84237cff2151b344a3a1d5ff16cc9f4fda0e

https://gerrit.wikimedia.org/r/757991

Change 756043 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Fix sorting bug in tables

https://gerrit.wikimedia.org/r/756043

Change 770638 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638

Change 770638 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638