Page MenuHomePhabricator

Oversighters need to be able to revert things to get rid of bad edits
Closed, ResolvedPublic

Description

Awareness of this need came out of reviewing patrolling workflows with @Risker. A user with the oversighter role needs to be able to perform reverts on any object they are patrolling so that they can remove offending content from a record before suppressing the edit which introduced the offending content.

In Django backend terms, this means that members of the Oversighter group need to be granted the "toolinfo.change_tool" permission. This will translate to a {subject: toolinfo/tool, action: change} permission in the CASL frontend rules.

Event Timeline

bd808 added a subscriber: Risker.

The need for this specific permission was missed when comparing rights to the rights granted to the analogous group in MediaWiki because of the different content controls in Toolhub. On a typical MediaWiki wiki anyone can edit any page. There are sometimes page specific protections that are slightly more restrictive, but there is very seldom a restriction like the core rule in Toolhub which gives "ownership" of a toolinfo record to a single individual.

Change 708320 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] api: Allow Oversighters to edit tools and lists

https://gerrit.wikimedia.org/r/708320

Change 708322 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] api: expand tests for toolinfo views

https://gerrit.wikimedia.org/r/708322

Change 708323 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] api: expand test for lists views

https://gerrit.wikimedia.org/r/708323

Change 708320 merged by jenkins-bot:

[wikimedia/toolhub@main] api: Allow Oversighters to edit tools and lists

https://gerrit.wikimedia.org/r/708320

Change 708322 merged by jenkins-bot:

[wikimedia/toolhub@main] api: expand tests for toolinfo views

https://gerrit.wikimedia.org/r/708322

Change 708323 merged by jenkins-bot:

[wikimedia/toolhub@main] api: expand test for lists views

https://gerrit.wikimedia.org/r/708323

bd808 moved this task from In Progress to Review on the Toolhub board.