Page MenuHomePhabricator

Provide more explanation in the 'badtitletext' message
Closed, ResolvedPublic

Description

Author: gangleri

Description:
I have no idea if
[http://test.wikipedia.org/wiki/User:Gangleri/tests/Unicode_ISO_88
59-1/%C2%AA%C2%AA_hacked_title %1A%1A hacked title] would be a
valid or an [[en:Wikipedia:Invalid article names|invalid article
name]] ([[ISO 8859-1]]).

http://test.wikipedia.org/wiki/User:Gangleri/tests/Unicode_ISO_885
9-1/%01%01_hacked_title generates a "Bad title" at [[test:]].

Maybe the "Bad title" page could provide informations more
specific to the actual "Bad title". I assume that the information
is available somewhere and should only be displayed.

Maybe it should be possible to add a project specific message
(some projects are [[UTF-8]] others [[ISO 8859-1]]) and both

  • links to usefull pages as [[meta:Help:Page name]],

[[meta:Help:Page name#Special characters|#Special characters]],
[[UTF-8]], [[ISO 8859-1]], [[Wikipedia:Special characters]]

  • and a place where to report this nvalid article name

[[Wikipedia:Invalid article names]].

I have no clue if this is a security issue (regarding integrity
of the database) as malicious entries in the namespace could be
made.

Releted: bug 563, bug 660.

Regards Reinhardt


Version: unspecified
Severity: minor
URL: http://test.wikipedia.org/wiki/User:Gangleri/tests/Unicode_ISO_8859-1/%1A%1A_hacked_title

Details

Reference
bz884
TitleReferenceAuthorSource BranchDest Branch
dev: destroy destroys all containersrepos/releng/cli!19addshoredev-destroy-fix-docmain
dev: Nicer error from MW if the DB doesn't existrepos/releng/cli!3addshoreno-postgre-error-on-no-dbsmain
Customize query in GitLab

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 7:00 PM
bzimport set Reference to bz884.
bzimport added a subscriber: Unknown Object (MLST).

zigger wrote:

(In reply to comment #0)

I have no idea if
[http://test.wikipedia.org/wiki/User:Gangleri/tests/Unicode_ISO_88
59-1/%C2%AA%C2%AA_hacked_title %1A%1A hacked title] would be a
valid or an [[en:Wikipedia:Invalid article names|invalid article
name]] ([[ISO 8859-1]]).

1.5 treats [[%C2%AA%C2%AA_hacked_title]] as an acceptable title.

http://test.wikipedia.org/wiki/User:Gangleri/tests/Unicode_ISO_885
9-1/%01%01_hacked_title generates a "Bad title" at [[test:]].

%01%01_hacked_title is still a bad title in 1.5.

Maybe the "Bad title" page could provide informations more
specific to the actual "Bad title". I assume that the information
is available somewhere and should only be displayed.

Maybe it should be possible to add a project specific message
(some projects are [[UTF-8]] others [[ISO 8859-1]]) and both

  • links to usefull pages as [[meta:Help:Page name]],

[[meta:Help:Page name#Special characters|#Special characters]],
[[UTF-8]], [[ISO 8859-1]], [[Wikipedia:Special characters]]

  • and a place where to report this nvalid article name

[[Wikipedia:Invalid article names]].

The imminent 1.5 only supports UTF-8. I'm marking this bug as an enhancement
request to improve the 'badtitletext' message. I don't see much need for
various alternative messages, as the current message can be expanded beyond its
current one line in English to be as explanatory as needed. The destination of
any links within the message is also a localisation issue.

I have no clue if this is a security issue (regarding integrity
of the database) as malicious entries in the namespace could be
made.

Rather than being a security issue, rejecting bad titles improves security.
The message already reveals reasons for title rejection; it just doesn't do it
very well.

robchur wrote:

Tweaked this in CVS a moment ago, but could use some input. Right now, it's:

"The requested page title was invalid, empty, or an incorrectly linked
inter-language or inter-wiki title. It may contain one more characters which
cannot be used in titles."

Ideas for futher changes?

zigger wrote:

(In reply to comment #2)

...
Ideas for futher changes?

This should give enough of a clue: "... may contain characters which cannot be
used in titles."

The message also seems to be used for some interwiki redirect loop, some move
condition, and some thumbnail condition. Too much for me to work out at the
moment sorry.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:20 AM