Page MenuHomePhabricator

in SpecialUserlogin: replace preg_match by isIP()
Closed, DeclinedPublic

Description

see title.
I'll patch this with enotif


Version: 1.4.x
Severity: normal

Details

Reference
bz960
TitleReferenceAuthorSource BranchDest Branch
Add extloc linktoolforge-repos/versions!4brennenwork/link-extlocmain
stub out basic group scraping and displaybrennen/extloc!1brennenwork/groupsmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 7:04 PM
bzimport set Reference to bz960.
bzimport added a subscriber: Unknown Object (MLST).

It's not using isIP() because it checks if the name *contains* an IP address, not if it is in its *entirety* an IP
address.

Further, the exact match check would fail due to the order of operations with normalization. That should be
separately fixed but is not the same issue.

(In reply to comment #1)

It's not using isIP() because it checks if the name *contains* an IP address,

not if it is in its *entirety* an IP

address.

Further, the exact match check would fail due to the order of operations with

normalization. That should be

separately fixed but is not the same issue.

Brion:
I thought this is the same (eg. either a name or - automatically by the script -
th IP address. Because I do not understand, what you mean, I propose you write a
small fix, so that I understand the difference.

In SpecialUserlogin.php -- what exactly shall replace the preg_match() call
therein ? Please can you place the "codelet" here ?

( Someone has objected already one time against another similar codepart in
UserTalkUpdate, which was not inserted by me )