Different list API endpoints order the tools contained in the list differently
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Slst2020
	Jan 31 2022, 1:57 PM

Description

/api/lists/{id}/ seems to return the tools in the order they were added in to the list
/api/lists/{list_pk}/revisions/{id}/ seems to return the tools in alphabetical order

Details

	Subject	Repo	Branch	Lines +/-
	toolhub: Bump container version to 2022-04-21-215651-production	operations/deployment-charts	master	+1 -1
	api: same ordering for lists and list revision	wikimedia/toolhub	main	+6 -2

Customize query in gerrit

Related Objects

Mentioned In: T293164: Implement UI for viewing list revision history, content diffs, and patrolling actions

Event Timeline

Slst2020 created this task.Jan 31 2022, 1:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2022, 1:57 PM

Slst2020 mentioned this in T293164: Implement UI for viewing list revision history, content diffs, and patrolling actions.Jan 31 2022, 2:06 PM

Raymond_Ndibe claimed this task.Apr 5 2022, 11:06 PM

Change 777457 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] api: same ordering for lists and list revision

https://gerrit.wikimedia.org/r/777457

gerritbot added a project: Patch-For-Review.Apr 5 2022, 11:13 PM

Raymond_Ndibe added a project: User-Raymond_Ndibe.Apr 5 2022, 11:13 PM

Raymond_Ndibe moved this task from Backlog to In Review on the User-Raymond_Ndibe board.

Raymond_Ndibe moved this task from Backlog to Review on the Toolhub board.Apr 6 2022, 12:13 AM

This patch has a weird bug.

To reproduce:

Create a new empty list.
Add the tool "Wiki Loves Monuments maps" to it
Go to MyLists: everything here looks good
Go to the list's List History, click on the most recent Revision

Expected behavior:

There is a list with a "Wiki Loves Monuments maps" ToolCard in it.

What really happens:

There are several "Wiki Loves Monuments maps" ToolCards in the list.

I created three different lists, each containing the "Wiki Loves Monuments maps" tool. When inspecting the latest revision,

the first list had 2 "Wiki Loves Monuments maps" ToolCards
the second had 3
the third had 4!

Screenshot 2022-04-07 at 16.38.28.png (1×2 px, 185 KB)

I tried doing the same thing on the main branch, but everything worked fine there.

Yes this is a weird bug and really interesting reading about it. I went through a couple of django issues before discovering this a known won't fix issue and was opened and closed 10 years ago. here is the link https://code.djangoproject.com/ticket/18165.
The first solution that solves it satisfactorily is to use .distinct(), but I can't say with confidence that this is the best solution. I'll submit a match with the distinct() approach however. If someone knows of a better solution, I'd be glad to talk about it.

Change 777457 merged by jenkins-bot:

[wikimedia/toolhub@main] api: same ordering for lists and list revision

https://gerrit.wikimedia.org/r/777457

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2022, 12:30 PM

Raymond_Ndibe closed this task as Resolved.Apr 12 2022, 5:14 PM

Change 786342 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-04-21-215651-production

https://gerrit.wikimedia.org/r/786342

gerritbot added a project: Patch-For-Review.Apr 26 2022, 3:48 PM

Change 786342 merged by jenkins-bot: