Page MenuHomePhabricator
Create Task
Maniphest T3090

Classic skins shows blank navigation links
Closed, ResolvedPublic
Actions

Description

Author: god

Description:
If the name of a navigation link is blank in Special:Allmessages, the Classic and Cologne Blue skins will try to
print it anyway, unlike the other skins. So, with a default installation you will see a "-" in the quickbar links
where "Site Support" was intended to be.

This bug is simple to reproduce: Create an account on test.wikipedia.org, and set your preferred skin to either of
those two skins, and you will see a blank link in the quickbar links. Same result in my installation, unless you
remove "Site Support" from $wgNavigationLinks, or define "sitesupport" in Allmessages.

Version: 1.4.x
Severity: minor

Details

Reference
bz1090
TitleReferenceAuthorSource BranchDest Branch
Add first gitlab-CI pipeline - Test onlyrepos/ci-tools/wmf-jvm-parent-pom!2joalbase_cimain
Add first gitlab-CI pipeline - Test onlyrepos/ci-tools/wmf-maven-tool-configs!2joalbase_cimain
Update from discovery to wmfrepos/ci-tools/wmf-jvm-parent-pom!1joalupdate_from_discovery_to_wmfmain
Update from discovery to wmfrepos/ci-tools/wmf-maven-tool-configs!1joalupdate_from_discovery_to_wmfmain
Customize query in GitLab

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:02 PM
• bzimport added a project: MediaWiki-User-Interface.
• bzimport set Reference to bz1090.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Dec 14 2004, 4:02 AM
• bzimport added a comment.Dec 14 2004, 4:05 AM

god wrote:

fixes the bug for the classic skin

Have only tested it on b2, but I see that the file hasn't changed in b3

Attached:

classic_skin_fix_qbar_links-mw1.4b2.diff1 KBDownload

• bzimport added a comment.Dec 14 2004, 4:08 AM

god wrote:

fixes the bug for Cologne Blue

Only tested on b2

Attached:

cologne_skin_fix_qbar_links-mw1.4b2.diff1 KBDownload

• brion added a comment.Dec 14 2004, 5:31 AM

Whoops, I fixed these a few days ago but forgot to check it in. :P

Done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL