Page MenuHomePhabricator

Fix bugs in published list view's autocomplete and full search functionalities
Closed, ResolvedPublicBUG REPORT

Description

There are a number of bugs in the autocomplete and full search functionalities of the published lists view:

  • While creating a new list, the list itself is indexed while the tools in the list are not added to the list index. As a result, trying to for a list by the name of the tools in the list immediately after the list is created comes up empty.
  • While trying to search for a list, clicking enter to perform the full search leaves the autocomplete suggestion dropdown still open. Ideally it should clear the search input and close the dropdown when user clicks enter.
  • The autocomplete search currently returns more items than the full search. This is because the autocomplete search does multi match searching, searching through many fields while the full search generally doesn't. Ideally the reverse should be the case. The full search should return more items than the autocomplete search.

Event Timeline

Change 803564 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] ui: Close autcomplete dropdown on search

https://gerrit.wikimedia.org/r/803564

Change 803566 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] api: call instance.save() in EditToolListSerializer create method

https://gerrit.wikimedia.org/r/803566

The third point in the issue description is not really a bug but the expected behavior. Right now the autocomplete search returns more items because it searches multiple fields. The first thing we should probably do is give the full search the ability to search on multiple fields too.

Change 803564 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Close autcomplete dropdown on search

https://gerrit.wikimedia.org/r/803564

Change 803566 merged by jenkins-bot:

[wikimedia/toolhub@main] api: call instance.save() in EditToolListSerializer create method

https://gerrit.wikimedia.org/r/803566

Change 810079 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-06-30-170012-production

https://gerrit.wikimedia.org/r/810079

Change 810079 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Bump container version to 2022-06-30-170012-production

https://gerrit.wikimedia.org/r/810079