Allow to dry_run RemoteHosts.wait_reboot_since() and PuppetHosts.wait_since()
Open, MediumPublic
Actions

Assigned To

None

Authored By

	JMeybohm
	Jun 21 2022, 10:17 AM

Description

It would be nice if RemoteHosts.wait_reboot_since() and PuppetHosts.wait_since() would work in dry_run.

Context: https://gerrit.wikimedia.org/r/c/operations/cookbooks/+/806285

Event Timeline

JMeybohm created this task.Jun 21 2022, 10:17 AM

Restricted Application added a project: SRE-tools. · View Herald TranscriptJun 21 2022, 10:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

jbond subscribed.Jun 21 2022, 11:37 AM

Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptJun 21 2022, 11:37 AM

joanna_borun removed a project: SRE-tools.Jun 19 2023, 2:44 PM

Restricted Application added a project: SRE-tools. · View Herald TranscriptJun 19 2023, 2:44 PM

@JMeybohm am I interpreting correctly that you're saying that those are raising an exception because the reboot or puppet run is not found and hence stops the DRY-RUN early on with a failure without allowing the DRY-RUN to continue?
So you're proposing that we're not raising in dry-run for those?

@JMeybohm could you confirm the above or give me more context?

Sorry, I must have missed the message. Yes, IIRC that is the correct interpretation.

Perfect, thanks for the update.

Allow to dry_run RemoteHosts.wait_reboot_since() and PuppetHosts.wait_since() Open, MediumPublicActions

Description

Event Timeline

Allow to dry_run RemoteHosts.wait_reboot_since() and PuppetHosts.wait_since()
Open, MediumPublic
Actions