Page MenuHomePhabricator
Create Task
Maniphest T313912

🥬️ Consistently check 'Content-Type:' header for all RouteHandlers
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

  • allowed value should be 'application/json' for required request bodies or no Content-Type for empty bodies
  • find out if the check must be performed in RouteHandler::validate() or can be moved into a middleware
  • ensure RouteHandler::getBodyValidator() returns a JsonBodyValidator only if the Content-Type is application/json

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Check request content type in middlewaremediawiki/extensions/Wikibasemaster+181 -27
REST: Only use JSON validator for JSON request bodymediawiki/extensions/Wikibasemaster+117 -112
Customize query in gerrit

Event Timeline

Silvan_WMDE created this task.Jul 27 2022, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2022, 1:46 PM
Silvan_WMDE set the point value for this task to 3.Jul 27 2022, 1:47 PM
Jakob_WMDE claimed this task.Aug 1 2022, 12:30 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 11) board.
gerritbot added a comment.Aug 1 2022, 3:37 PM

Change 819103 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Only validate JSON for JSON request body

https://gerrit.wikimedia.org/r/819103

gerritbot added a project: Patch-For-Review.Aug 1 2022, 3:37 PM

Change 819104 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Check request content type in middleware

https://gerrit.wikimedia.org/r/819104

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 1 2022, 4:44 PM
gerritbot added a comment.Aug 2 2022, 3:49 PM

Change 819103 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Only use JSON validator for JSON request body

https://gerrit.wikimedia.org/r/819103

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 2 2022, 4:00 PM
gerritbot added a comment.Aug 3 2022, 11:18 AM

Change 819104 merged by Silvan Heintze:

[mediawiki/extensions/Wikibase@master] REST: Check request content type in middleware

https://gerrit.wikimedia.org/r/819104

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2022, 11:30 AM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 3 2022, 11:44 AM
Aklapper closed this task as Resolved.Oct 10 2022, 9:53 AM

@Jakob_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits