DeadLinkFinder seems to hang in status "check ongoing" forever
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	M2k_dewiki
	Sep 29 2022, 9:40 AM

Description

Hello,

at least in the german language wikipedia there is a tool to check external links for every page.

In the left navigation bar there are the links

"Links überprüfen" -> javascript:DeadLinkFinder.start()
"Links immer überpüfen" -> javascript:DeadLinkFinder.startAlwaysCheckingForDeadLinks()
"keine Links mehr überprüfen" -> javascript:DeadLinkFinder.stopAlwaysCheckingForDeadLinks()

The tool seems to hang in status "check ongoing" (check icon in the down right corner) forever, even for articles/pages with almost no weblinks, for example:

https://de.wikipedia.org/wiki/Fabio_Tognetti

Only if there are no external links the green "OK" icon is show in the down right corner:

https://de.wikipedia.org/wiki/Kirche_Sch%C3%B6nenberg

Could you please check?

Thanks a lot!

Event Timeline

M2k_dewiki created this task.Sep 29 2022, 9:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2022, 9:40 AM

The tool seems to be

https://de.wikipedia.org/wiki/Benutzer:Frog23/Dead_Link_Finder/en

The problem might be related to

https://de.wikipedia.org/wiki/Benutzer_Diskussion:Frog23/Dead_Link_Finder/de#dead_link_finder

This seems to be about https://deadlinkfinder.toolforge.org/script.js . Unfortunately https://toolsadmin.wikimedia.org/tools/id/deadlinkfinder lists no information where to find its code base or where to file bug reports. CC'ing @Frog23 - could you please clarify? Thanks a lot!

@Frog23 Could you please answer the last comment? Thanks in advance!

Also see

https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#28._September

https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Gibt_es_einen_Bot,_der_nicht_erreichbare_Seiten_im_Abschnitt_'Weblinks'_eines_Artikels_erkennen_m%C3%BCsste?

Hey everybody, sorry for not checking in here earlier. It has been a couple of busy weeks IRL.

Anyways, thanks for the report @M2k_dewiki and thanks for adding me @Aklapper . I have looked into this issue and found the problem. It had to do with the pre-flight CORS request from the browser to the server. I don't know what changed, but somehow they stopped working. However in the meantime (I have last touched the tool 5 years ago) a lot of things have changed on the WMF side, so I was able to implement a fix that I couldn't back when I initially wrote it (OPTIONS requests/responses), so that should have solved the problem.

When I now run it on https://de.wikipedia.org/wiki/Fabio_Tognetti it indicates an issue with a link, but doesn't highlight a link as problematic but this is because two other external links are hidden in the template but recognized by the script which then causes a problem.

I am aware that I do need to spend some time on getting the tool up to date, e.g. by properly filling out the infos for https://toolsadmin.wikimedia.org/tools/id/deadlinkfinder etc, but I won't be able to do this for at least the next 5 weeks. But for now the main issue is fixed and it should be working. Let me know if you encounter any other issues with it.

Hello Frog23,

thanks a lot! For me, at the page

https://de.wikipedia.org/wiki/Fabio_Tognetti

the tool still shows the "waiting" icon in the down right bottom corner:

https://de.wikipedia.org/wiki/Datei:WP-Dead-Link-Finder-6-Waiting-Icon.png

Is it necessary to change someting in the javascript configuation/initialization or the browser settings/cache ?

Thanks a lot!

Could be a caching issue. Try loading https://deadlinkfinder.toolforge.org/script.js directly in the browser and maybe pressing Ctrl + F5 to refresh. The link in the second line of the Privacy Information should be https://deadlinkfinder.toolforge.org/ and not https://tools.wmflabs.org. This way you know, that you have the correct version.

How have you included the script in your user profile?
I hope this helps.

Thanks! It also works for me now!

I changed the URL in

https://de.wikipedia.org/wiki/Benutzer:M2k~dewiki/common.js

from

mw.loader.load("tools.wmflabs.org/deadlinkfinder/script.js"); [[Benutzer:Frog23/Dead Link Finder/de]]

mw.loader.load("deadlinkfinder.toolforge.org/script.js"); [[Benutzer:Frog23/Dead Link Finder/de]]

Afterwards I cleaned the browser cache.

Also see

https://de.wikipedia.org/w/index.php?title=Benutzer%3AFrog23%2FDead_Link_Finder%2Fde&type=revision&diff=226961918&oldid=146518133

https://de.wikipedia.org/w/index.php?title=Benutzer%3AFrog23%2FDead_Link_Finder%2Fen&type=revision&diff=226961940&oldid=124825408

DeadLinkFinder seems to hang in status "check ongoing" foreverClosed, ResolvedPublicBUG REPORTActions

Description

Event Timeline

DeadLinkFinder seems to hang in status "check ongoing" forever
Closed, ResolvedPublicBUG REPORT
Actions