Page MenuHomePhabricator

Different import sources causing reverts multiple times a day
Closed, ResolvedPublicBUG REPORT

Description

What happens?:

Import sources can edit war with each other.

What should have happened instead?:

No edit warring from imports

Example:
For https://toolhub.wikimedia.org/tools/toolforge-authors/history imports from https://toolsadmin.wikimedia.org/tools/toolinfo/v1.2/toolinfo.json and https://authors.toolforge.org/toolinfo.json are causing reverts multiple times a day.

Event Timeline

bd808 triaged this task as High priority.
bd808 moved this task from Backlog to Review on the Toolhub board.
bd808 subscribed.

In a normal situation there is no edit war as the import process crawls the URLs in a deterministic order and enforces a constraint that the first import of a given toolinfo record name wins.

The root cause of this edit warring is a bug where the https://toolsadmin.wikimedia.org/tools/toolinfo/v1.2/toolinfo.json URL is timing out multiple times a day and dropping the "primary" record from https://toolsadmin.wikimedia.org/tools/id/authors when that happens. I wrote https://gerrit.wikimedia.org/r/c/wikimedia/toolhub/+/852301 as an attempt at fixing this, but apparently never actually remembered to deploy it. :/

Change 868183 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: bump container to 2022-12-14-185830-production

https://gerrit.wikimedia.org/r/868183

Change 868183 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: bump container to 2022-12-14-185830-production

https://gerrit.wikimedia.org/r/868183